Add flag to modify the maximum amount of usable ServerLinks#85
Merged
theEvilReaper merged 2 commits intomasterfrom Oct 21, 2024
Merged
Add flag to modify the maximum amount of usable ServerLinks#85theEvilReaper merged 2 commits intomasterfrom
theEvilReaper merged 2 commits intomasterfrom
Conversation
|
|
In the future, we should add a test for the packet to verify the link amount limit. For now, though, it looks good |
TheMeinerLP
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Add flag for the maximum amount of ServerLinks * Update constant usage
TheMeinerLP
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Add flag for the maximum amount of ServerLinks * Update constant usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed changes
The current maximum number of
ServerLinkssupported by the server is hardcoded into the specific packet structure. While this behavior is generally not an issue, it becomes problematic if a situation arises where a different limit is required, as it's not possible to adjust it. This pull request introduces a flag in theServerFlagclass, which can now be modified through a parameter.Closes #83
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.